Skip to content

Commit

Permalink
SUFFIX を追加し、GitHub Actions の github.run_id を利用する
Browse files Browse the repository at this point in the history
  • Loading branch information
voluntas committed Feb 21, 2024
1 parent 071af1d commit bd80c61
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
- run: pnpm run build
- run: pnpm exec playwright install --with-deps
- run: pnpm exec playwright test --project=${{ matrix.browser }}
env:
VITE_SORA_CHANNEL_ID_SUFFIX: _${{ github.run_id }}-${{ matrix.node }}
# - uses: actions/upload-artifact@v4
# if: always()
# with:
Expand Down
3 changes: 2 additions & 1 deletion examples/messaging/main.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ import Sora from '../../dist/sora.mjs'

const SORA_SIGNALING_URL = import.meta.env.VITE_SORA_SIGNALING_URL
const SORA_CHANNEL_ID_PREFIX = import.meta.env.VITE_SORA_CHANNEL_ID_PREFIX
const SORA_CHANNEL_ID_SUFFIX = import.meta.env.VITE_SORA_CHANNEL_ID_SUFFIX
const ACCESS_TOKEN = import.meta.env.VITE_ACCESS_TOKEN

const debug = true
const sora = Sora.connection(SORA_SIGNALING_URL, debug)

const channelId = `${SORA_CHANNEL_ID_PREFIX}messaging`
const channelId = `${SORA_CHANNEL_ID_PREFIX}messaging${SORA_CHANNEL_ID_SUFFIX}`
const metadata = { access_token: ACCESS_TOKEN }
const options = {
dataChannelSignaling: true,
Expand Down
3 changes: 2 additions & 1 deletion examples/spotlight_recvonly/main.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import Sora from '../../dist/sora.mjs'

const SORA_SIGNALING_URL = import.meta.env.VITE_SORA_SIGNALING_URL
const SORA_CHANNEL_ID_PREFIX = import.meta.env.VITE_SORA_CHANNEL_ID_PREFIX
const SORA_CHANNEL_ID_SUFFIX = import.meta.env.VITE_SORA_CHANNEL_ID_SUFFIX
const ACCESS_TOKEN = import.meta.env.VITE_ACCESS_TOKEN

const channelId = `${SORA_CHANNEL_ID_PREFIX}spotlight_sendonly_recvonly`
const channelId = `${SORA_CHANNEL_ID_PREFIX}spotlight_sendonly_recvonly${SORA_CHANNEL_ID_SUFFIX}`
const debug = false
const sora = Sora.connection(SORA_SIGNALING_URL, debug)
const metadata = { access_token: ACCESS_TOKEN }
Expand Down

0 comments on commit bd80c61

Please sign in to comment.