非公開 API が含まれていた場合エラーにする #224
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miosakuma
approved these changes
Jan 24, 2025
zztkm
reviewed
Jan 24, 2025
.github/workflows/build.yml
Outdated
| @@ -35,6 +35,11 @@ jobs: | |||
| rm Podfile && mv Podfile.dev Podfile | |||
| pod repo update | |||
| pod install | |||
| if nm ./Pods/WebRTC/WebRTC.xcframework/ios-arm64/WebRTC.framework/WebRTC | grep _kVTVideoEncoderSpecification_RequiredLowLatency >/dev/null 2>&1; then | |||
| echo 'Error: Non-public API detected in WebRTC framework.' | |||
| rm -rf Pods/ Podfile.lock Sora.xcworkspace/ | |||
There was a problem hiding this comment.
失敗だった場合 pod install を削除してクリアな状態に戻したいという意図です。
キャッシュを使っているようでしたので残さない方が良い判断です。
There was a problem hiding this comment.
ありがとうございます。
キャッシュ削除ということで納得です。
zztkm
approved these changes
Jan 24, 2025
|
pod install の時に生成されるので Sora.xcworkspace/ の削除は不要ですね。この削除部分を修正して、マージします。 |
|
ありがとうございます！ |
|
4823237 で削除しました。CI が通り次第マージします。 |
|
キャッシュはジョブが正常に行われた時に実行されるため、rm は不要でした。削除します。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI 実行時に依存パッケージに非公開 API が含まれていた場合エラーにするようにしました。
非公開 API が含まれていると Apple の審査が通らないため、事前に確認することを目的としています。
今回追加したのは
_kVTVideoEncoderSpecification_RequiredLowLatencyをチェックするようにしています。This pull request includes an important change to the
jobs:section in the.github/workflows/build.ymlfile. The change introduces a check for non-public APIs in the WebRTC framework during the build process.Build process improvement:
.github/workflows/build.yml: Added a check to detect the presence of the_kVTVideoEncoderSpecification_RequiredLowLatencysymbol in the WebRTC framework. If detected, the build process will output an error message, remove thePods/,Podfile.lock, andSora.xcworkspace/directories, and exit with an error status.