Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to new benchmark tool #596

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Small improvements to new benchmark tool #596

merged 4 commits into from
Oct 18, 2024

Conversation

joanaxcruz
Copy link
Contributor

What is the purpose of this pull request?

  • Fix a bug
  • Improve code quality or performance
  • Documentation update

What changes did you make?

  • Add paragraph in documentation of new benchmark tool about its multiple output format feature;
  • Correct typo in sve benchmarks (scalar --> sve);
  • Lower optimisation level when compiling benchmarks (O3 --> O2) - otherwise optimizes calls to functions that return 2 values, such as sincos;
  • Make sure CXX is enabled when benchmarks are built, since they use C++.

@joanaxcruz
Improve documents for benchmark tool
c8b726f 
Add paragraph on multiple output format feature.
@joanaxcruz
Decrease optimization level for compiling benchmarks
ad582e4 
Calls to functions which return two values (for example sincos),
were being optimized away in new benchmark tool. Fixed by
decreasing optimization level (O3 -> O2).
@joanaxcruz
Ensure CXX is enable when benchmarks are built
65bdfa0 
When benchmarks are built, SLEEF_ENABLE_CXX should be
set to ON, since they use cpp.
@joanaxcruz
Correct name identifier for sve functions in benchmark tool
46abb98 
Used to be scalar, now is sve.
@blapie blapie merged commit a28c645 into shibatch:master Oct 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joanaxcruz @blapie