Reenable quad and double precision in libm #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545. Change-Id: I2e4efa4682e05d351535cf66cfc4adc806f6a67b
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
blapie
added a commit
to blapie/sleef
that referenced
this pull request
May 31, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API shibatch#534. Test should fail until it is fixed by shibatch#545.
joanaxcruz
force-pushed
the
joaxcru/reenable_quad_double
branch
from
e10f191
to
f485670
Compare
In the transition between sleef-3.5 and sleef-3.6, support
for quad and long precision was dropped.
This resulted in 4 funtions being removed from the ABI:
[D] 'function const Sleef_longdouble2 Sleef_sincospil_u05(long double)' {Sleef_sincospil_u05}
[D] 'function const Sleef_longdouble2 Sleef_sincospil_u35(long double)' {Sleef_sincospil_u35}
[D] 'function const Sleef_quad2 Sleef_sincospiq_u05(Sleef_quad)' {Sleef_sincospiq_u05}
[D] 'function const Sleef_quad2 Sleef_sincospiq_u35(Sleef_quad)' {Sleef_sincospiq_u35}
By reverting these changes and bring these functions back to the ABI.
This reverts commit 64c957f.
Completed definition for Sleef_quad in `quaddef.h` where it can be used by sleefqp.c Note quad precision is not available for aarch64, as it does not support quadmath library.
joanaxcruz
force-pushed
the
joaxcru/reenable_quad_double
branch
from
f485670
to
da8e42c
Compare
blapie
added a commit
that referenced
this pull request
Oct 9, 2024
Add a new workflow to detect unexpected backward-incompatible changes at precommit, by comparing current version against a reference version, both generated on Linux with gcc. It uses abidiff to compare ELF-format shared libraries. This is the tool used by Fedora to report a recent breach in API #534. Test should fail until it is fixed by #545.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest release (3.6.0), there were some unexpected ABI changes as pointed out in #534.
We try to restore the functions that were lost by reenabling quad and double precision in libm.