Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error with IntelLLVM compiler #492

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

iskunk
Copy link
Contributor

@iskunk iskunk commented Dec 13, 2023

I am building sleef using the IntelLLVM (oneAPI) 2024.0.0 compiler. This error comes up immediately:

$ make
[  0%] Building C object src/libm/CMakeFiles/mkrename_gnuabi.dir/mkrename_gnuabi.c.o
error: unknown argument '--extended_float_type'; did you mean '--extended_float_types'?
make[2]: *** [src/libm/CMakeFiles/mkrename_gnuabi.dir/build.make:76: src/libm/CMakeFiles/mkrename_gnuabi.dir/mkrename_gnuabi.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:838: src/libm/CMakeFiles/mkrename_gnuabi.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

If I add the "s" to the offending flag, I see this later in the build:

icx: warning: overriding '-ffp-model=fast=2' option with '-ffp-model=fast' [-Woverriding-t-option]

This page in Intel's documentation does not indicate any numeric suboption to -fp-model=fast.

This PR adds a conditional to Configure.cmake that uses the modified values for the IntelLLVM variant. With this change, I get a clean build.

Note: Intel online community posts imply that the Intel Classic compiler may accept the --extended_float_types (plural) option in addition to the singular form, but I do not have a way of verifying this.

@blapie blapie mentioned this pull request Jan 2, 2024
@xuhancn
Copy link
Contributor

xuhancn commented Jan 2, 2024

Please close my PR(#497) after merge this PR.

@xuhancn
Copy link
Contributor

xuhancn commented Jan 7, 2024

Could you please priority to merge this PR? Our project depends on it. @blapie

@blapie blapie merged commit ecb8936 into shibatch:master Jan 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants