Do not define our own mpfr_sinpi/mpfr_cospi for mpfr 4.2.0 and later #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@musicinmybrain Hello, Would you mind rebasing your branch on top of master so we can test this through the new CI? Cheers |
musicinmybrain
force-pushed
the
mpfr-sin-cos-pi
branch
from
1f27275
to
a58ce79
Compare
Done! |
|
@musicinmybrain Brilliant, thanks! Should be able to merge next week, thanks a lot for the contribution! |
|
@musicinmybrain Hi! Could you please rebase again so it picks up the last CI checks? Will merge after. Thanks! |
These two functions were added to the MPFR API. Fixes shibatch#458.
musicinmybrain
force-pushed
the
mpfr-sin-cos-pi
branch
from
a58ce79
to
8e84d24
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions were added to the MPFR API.
Fixes #458.
This is offered as alternative to #462, in case you would like to maintain backwards compatibility with MPFR versions earlier than 4.2.0. I don’t view either PR as better than the other; it’s merely a matter of choice.