Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

sherlock-audit/2024-09-orderly-network-solana-contract

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

28 Commits
 
 
 
 
 
 
 
 

Repository files navigation

Orderly Network Solana Contract contest details

Q&A

Q: On what chains are the smart contracts going to be deployed?

Deploy Solana-Vault on Solana, and deploy SolConnector on Orderly Chain (OP Stack L2 EVM)


Q: If you are integrating tokens, are you allowing only whitelisted tokens to work with the codebase or any complying with the standard? Are they assumed to have certain properties, e.g. be non-reentrant? Are there any types of weird tokens you want to integrate?

Yes, currently only support USDC deposit on Solana chain


Q: Are there any limitations on values set by admins (or other roles) in the codebase, including restrictions on array lengths?

No limitation on values


Q: Are there any limitations on values set by admins (or other roles) in protocols you integrate with, including restrictions on array lengths?

No


Q: For permissioned functions, please list all checks and requirements that will be made before calling the function.

Require caller is Owner/Admin account/address


Q: Is the codebase expected to comply with any EIPs? Can there be/are there any deviations from the specification?

No, it is a Solana program


Q: Are there any off-chain mechanisms for the protocol (keeper bots, arbitrage bots, etc.)? We assume they won't misbehave, delay, or go offline unless specified otherwise.

No


Q: If the codebase is to be deployed on an L2, what should be the behavior of the protocol in case of sequencer issues (if applicable)? Should Sherlock assume that the Sequencer won't misbehave, including going offline?

We hold the L2, Sequencer won't misbehave


Q: What properties/invariants do you want to hold even if breaking them has a low/unknown impact?

The USDC balance of Vault pgram on Solana is no less than the Vault balance record on Ledger contract on Orderly chain


Q: Please list any known issues and explicitly state the acceptable risks for each known issue.

Front-running during PDA initialisation is considered known and acceptable.


Q: We will report issues where the core protocol functionality is inaccessible for at least 7 days. Would you like to override this value?

No


Q: Please provide links to previous audits (if any).

No


Audit scope

sol-cc @ dc99b068cda9a6067b35edf629acd1730e5982a3

solana-vault @ bd8b6dbeb3300319fd9dad262298ec0cd1152344

sol-cc @ dc99b068cda9a6067b35edf629acd1730e5982a3