refactor: extract session restore related code behind a trait #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aetf
force-pushed
the
term-trait
branch
2 times, most recently
from
565b523 to
205a522
Compare
|
Since this also fixes a bug in the code. Let's get this submitted while I keep working on it. |
ethanpailes
reviewed
Oct 21, 2024
This prepares us for more session restore backends in the future. This also fixes a bug in the code where the vt100 internal state is initialized to vterm_width, but will reset to u16::MAX on resize events.
ethanpailes
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares us for more session restore backends in the future.