Add tests for the /motd command #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host_test.go
Outdated
| @@ -107,9 +117,7 @@ func TestHostNameCollision(t *testing.T) { | |||
| scanner := bufio.NewScanner(r) | |||
|
|
|||
| // Consume the initial buffer | |||
| scanner.Scan() | |||
There was a problem hiding this comment.
-0.5 on this change, not worth it unless we're doing this for large N (like >5). More clear to avoid the extra indirection otherwise.
There was a problem hiding this comment.
I think there are only one case where N>5 (:> N=8) - do you think it is worth keeping the function then? The eight calls to scanner.Scan() aren't "pretty" but at least there is one way to do it (decrease the cognitive cost of figuring out what is going on). Wdyt?
There was a problem hiding this comment.
Ah fair enough, let's hang onto it for now.
|
Make sure it builds. :) I suggest using go integration with your editor, it'll do it automagically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.