Demo Website #263
Merged
Demo Website #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of having to run a server
rosstroha
force-pushed
the
preact-demo-website
branch
from
694968e to
83434d0
Compare
disnet
reviewed
Jul 10, 2024
There was a problem hiding this comment.
this file should probably be automatically updated as part of mvn install so we don't forget to copy/paste in the future (unless it already does and I missed it)
There was a problem hiding this comment.
I remember discussing this with Kevin. It was decided that we didn't need to do this since salvation isn't changed that often
There was a problem hiding this comment.
I'll try to find the conversation just to make sure I am not confusing details.
There was a problem hiding this comment.
oh actually, in that case we should probably update the readme to call out you need to manually copy it out of the target directory
disnet
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.