Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Stop using "Object" in MediaSourceEngine annotations #7998

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 31, 2025

Related to #1672

@avelad avelad added the type: code health A code health issue label Jan 31, 2025
@avelad avelad added this to the v4.14 milestone Jan 31, 2025
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jan 31, 2025

Incremental code coverage: 86.21%

avelad and others added 2 commits January 31, 2025 11:55
@avelad avelad requested a review from tykus160 January 31, 2025 11:41
@avelad avelad merged commit 5f2b979 into shaka-project:main Jan 31, 2025
18 checks passed
@avelad avelad deleted the MediaSourceEngine-object branch January 31, 2025 12:09
avelad added a commit that referenced this pull request Feb 5, 2025
Related to #1672

---------

Co-authored-by: Wojciech Tyczyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code health A code health issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants