feat: Save CEA708 caption cues on all windows when deleting/clearing windows #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
darrinliam
changed the title
darrinliam
changed the title
|
Incremental code coverage: 100.00% |
|
Closing. I will open a new PR shortly using a different git user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7907
While Shaka's CEA708 parser currently creates each simultaneous subtitle cue window individually via defineWindow_(), Shaka emits the simultaneous captions all at once via deleteWindows_(). Only the last cue with the same start/end time is saved. The others are overwritten by deleteWindows_().
This PR addresses the above asymmetry by saving all cues on windows with the same start/end time when deleting/clearing windows. A slight refactoring was needed to use arrays to hold more than one parsed caption when handling C1 group data.