Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save CEA708 caption cues on all windows when deleting/clearing windows #7907

Closed
darrinliam opened this issue Jan 17, 2025 · 0 comments · Fixed by #7909
Closed

Save CEA708 caption cues on all windows when deleting/clearing windows #7907

darrinliam opened this issue Jan 17, 2025 · 0 comments · Fixed by #7909
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release type: enhancement New feature or request
Milestone

Comments

@darrinliam
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

Our organization has DASH H265 assets containing CEA708 captions with the same start/end times of other captions, where each said caption is encoded into a different cue window. We would like the Shaka Player to extract all captions from such assets.

Describe the solution you'd like

While Shaka's CEA708 parser currently creates each simultaneous subtitle cue window individually via defineWindow_(), Shaka emits the simultaneous captions all at once via deleteWindows_(). Only the last cue with the same start/end time is saved. The others are overwritten by deleteWindows_().

I will open a PR to address the above asymmetry by saving all cues on windows with the same start/end time when deleting/clearing windows.

Describe alternatives you've considered

Additional context

Are you planning to send a PR to add it?
Yes

@darrinliam darrinliam added the type: enhancement New feature or request label Jan 17, 2025
@shaka-bot shaka-bot added this to the Backlog milestone Jan 17, 2025
@tykus160 tykus160 added component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Jan 20, 2025
@tykus160 tykus160 modified the milestones: Backlog, v4.13 Jan 20, 2025
@avelad avelad closed this as completed in 19bd472 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants