Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Nameplates: Low Health, Name Reaction Colors #1182

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GryllsAddons
Copy link

A couple of ideas which might be useful to add to the nameplates.

Low Health Colors will color the health bar when at 20% health or lower (different color for friendlies and enemies)
Name Reaction Colors will color the unit's name by reaction (helpful when using it with the class color health bar option)

The code could possibly be improved but thought i'd leave this here as a proof of concept/suggestion!

Thanks!

lowhealthc

namereactionc

@shagu
Copy link
Owner

shagu commented Jul 24, 2023

Hi,
Thanks for the PR. I like the idea of the low-health display, but I would prefer it to have it begin to slowly fade to red when the unit goes below 50%, but I can't be bothered to do the math right now :D

Regarding the name colors, I see the need, but it also has the downside to no longer see the infight notifications.
Personally I'm fine with it, but I already see the questions incoming why the infight name color change is no longer visible 🙈

@GryllsAddons
Copy link
Author

GryllsAddons commented Jul 30, 2023

Thanks for the review!

I really like your idea of fading, I'll leave that to you as the colour math goes over my head! 😄 it would be great to add something as it's really useful to know at a glance when people/mobs are low or can be executed.

With the name colors it's a difficult one! I can see the value of the infight colors and it would be a shame to lose that piece of information. I've been trying to think of ideas of how to have both reaction and combat info visible at a glance while keeping the nameplates simple and uncluttered.

One idea I thought of was to include an option for a combat icon. I've uploaded a commit (see pic below) that will show/hide the icon/level while in combat.

I'll have a go at some other solutions as well and perhaps find something that works well to blend both!

image

@shagu shagu changed the title Nameplates: Low Health, Name Reaction Colors [WIP] Nameplates: Low Health, Name Reaction Colors Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants