fix:(shadcn) Resolve directory location issues #5484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues with incorrect directory resolution and import paths in the CLI package.
Related Issues
#5436
Summary of Changes
transformImport
function to correctly handle import paths, especially forutils
imports.Key Code Changes
1. Directory Resolution Fix
Removed problematic code in
update-files.ts
:This fix ensures correct installation location, but potential side effects need review.
2. Import Path Transformation
Updated transformImport in transform-import.ts
Removing the check for
cnImport
and still output the correct import pathThis may has potential side effects need review
Alias Handling
Files Changed
packages/shadcn/src/utils/transformers/transform-import.ts
packages/shadcn/src/utils/updaters/update-files.ts
packages/shadcn/test/utils/__snapshots__/transform-import.test.ts.snap
packages/shadcn/test/utils/schema/__snapshots__/registry-resolve-items-tree.test.ts.snap
packages/shadcn/test/utils/transform-import.test.ts
Testing
Please review the changes and let me know if any adjustments are needed.
Thanks