Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [Sidebar Component] add missing installation step in the sidebar component documentation #5467

Merged

Conversation

daddou-ma
Copy link
Contributor

Issue: When adding the sidebar component manually to an existing project, the sidebar styles are not applied.

Cause: The current setup guide for sidebar components is missing the step to add the sidebar config in to tailwind.config.js

Solution: I've added the step in the sidebar documentation explaining how to activate sidebar related styles utilities

image

Copy link

vercel bot commented Oct 20, 2024

@daddou-ma is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@shadcn
Copy link
Collaborator

shadcn commented Oct 21, 2024

I think we only need this in the manual section. The CLI should take care of this. did it not work?

@shadcn shadcn added the postpone: more info or changes requested maintainers asked a question or needs more info label Oct 21, 2024
@daddou-ma
Copy link
Contributor Author

@shadcn I wasn't able to test it with cli (related to my project sturcture), only manual didn't work for me. I'll remove it from the CLI part.

@daddou-ma daddou-ma force-pushed the docs-sidebar-add-missing-installation-step branch from f85e596 to 72103a3 Compare October 21, 2024 08:09
@daddou-ma
Copy link
Contributor Author

@shadcn I've updated the PR, now the extra step is only in the manual part.

@daddou-ma daddou-ma force-pushed the docs-sidebar-add-missing-installation-step branch 2 times, most recently from b454ec6 to 676aac2 Compare October 21, 2024 09:17
@daddou-ma daddou-ma force-pushed the docs-sidebar-add-missing-installation-step branch from 676aac2 to b6dc9ea Compare October 22, 2024 08:05
Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 0d31293 into shadcn-ui:main Oct 22, 2024
4 of 5 checks passed
@shadcn shadcn added documentation Improvements or additions to documentation area: www component: sidebar and removed postpone: more info or changes requested maintainers asked a question or needs more info labels Oct 22, 2024
@daddou-ma daddou-ma deleted the docs-sidebar-add-missing-installation-step branch October 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: www component: sidebar documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants