Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: “border-boder” “border-primary” duplicates (e.g. “checkbox”, “radio-group”) #4745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph0926
Copy link

@joseph0926 joseph0926 commented Sep 5, 2024

What was the problem

  • If you didn't include css variables in your initial setup, we converted them, and the special treatment for “border” resulted in duplicate styling for “border”.

Where's the problem with the file?

  • transform-css-vars.ts/applyColorMapping Fn

How I fixed it

  • We are deduplicating for “border” behind the scenes, but “border-primary” is not caught by this branch (more on why in the link below), so we added a conditional to convert it to “border-boder” when it is not a “border-primary”.

Related issues

Check for PR

  • Passed local tests
  • Ensure that nothing other than the modification is affected

Copy link

vercel bot commented Sep 5, 2024

Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@joseph0926
Copy link
Author

If this is incorrect, please close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant