Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update zod imports #2466

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

kevinmitch14
Copy link
Contributor

@kevinmitch14 kevinmitch14 commented Jan 17, 2024

As of v3 of zod, using import * as z from "zod" is no longer required, see here.

This PR aligns all zod imports to match import { z } from "zod"
Both methods are already used in the project.

This also aligns imports to match zod documentation.
Screenshot 2024-01-17 at 10 57 38

Copy link

vercel bot commented Jan 17, 2024

@kevinmitch14 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@kevinmitch14 kevinmitch14 marked this pull request as ready for review January 17, 2024 13:59
@shadcn
Copy link
Collaborator

shadcn commented Jan 18, 2024

Oh good to know. Thank you.

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2024 8:46am

@shadcn shadcn added the fix A code style fix. label Jan 18, 2024
@shadcn
Copy link
Collaborator

shadcn commented Jan 18, 2024

@kevinmitch14 any chance you can break the cli changes in a separate PR? We'll need a changeset for it. Thanks.

@kevinmitch14 kevinmitch14 reopened this Jan 18, 2024
@kevinmitch14
Copy link
Contributor Author

apps/* changes

@kevinmitch14
Copy link
Contributor Author

CLI changes made in #2473

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 7df1007 into shadcn-ui:main Jan 28, 2024
11 checks passed
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants