Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): remove incorrect nested li from pagination link #2190

Conversation

takeshikriang
Copy link
Contributor

@takeshikriang takeshikriang commented Dec 25, 2023

I got this error from Next.js 14 telling about a <li> nested insied <li> on Pagination component.

Warning: validateDOMNesting(...): <li> cannot appear as a descendant of <li>.
screenhot

Copy link

vercel bot commented Dec 25, 2023

@takeshikriang is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@stathis1998
Copy link

Someone please merge this, thanks.

@shadcn shadcn added bug Something isn't working component: pagination labels Jan 18, 2024
Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 6:55am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@takeshikriang
Copy link
Contributor Author

Great, thanks.

@takeshikriang takeshikriang deleted the fix(pagination)/remove-incorrect-nested-li-from-pagination-link branch January 22, 2024 10:22
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
…dcn-ui#2190)

* feat: remove PaginationItem

* chore: build registry

---------

Co-authored-by: shadcn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: pagination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants