fix(#1686): remove redundant children prop
#1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gravy59 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
jocarrd
approved these changes
Oct 14, 2023
|
Interesting. It looks like we're not rendering I wonder if we need something like this instead: |
shadcn
added
the
area: roadmap
shadcn
added
the
postpone: more info or changes requested
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
removed
the
postpone: more info or changes requested
shadcn
approved these changes
Nov 12, 2023
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
This pull request resolves shadcn-ui#1686. ## Rationale for this PR This PR affects the code for `RadioGroupItem` in both styles by removing the `children` prop from the component. The children prop is automatically passed in by the use of the spread operator (`...props`) and is redundant because it is never used in the component. This PR shouldn't affect tests, representation, etc. and is merely a cosmetic change. There is no urgent need to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1686.
Rationale for this PR
This PR affects the code for
RadioGroupItemin both styles by removing thechildrenprop from the component. The children prop is automatically passed in by the use of the spread operator (...props) and is redundant because it is never used in the component.This PR shouldn't affect tests, representation, etc. and is merely a cosmetic change. There is no urgent need to merge this.