Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't allow empty chat messages #1137

Merged
merged 6 commits into from
Aug 25, 2023
Merged

fix: Don't allow empty chat messages #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
634efeb
fix: dont allow empty chat messages to send
kevinmitch14 Aug 7, 2023
e1fb207
fix: new york version to match default
kevinmitch14 Aug 7, 2023
7a8b14d
fix: add sr-only className to match new york
kevinmitch14 Aug 7, 2023
b1a5146
fix: remove autocomplete for chat messages
kevinmitch14 Aug 9, 2023
b4d9c00
refactor: track input value instead of length
kevinmitch14 Aug 13, 2023
089deb8
Merge branch 'main' into chat-example
shadcn Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions apps/www/registry/default/example/cards/chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export function CardsChat() {
content: "I can't log in.",
},
])
const [input, setInput] = React.useState("")
const inputLength = input.trim().length

return (
<>
Expand All @@ -115,6 +117,7 @@ export function CardsChat() {
onClick={() => setOpen(true)}
>
<Plus className="h-4 w-4" />
<span className="sr-only">New message</span>
</Button>
</TooltipTrigger>
<TooltipContent sideOffset={10}>New message</TooltipContent>
Expand Down Expand Up @@ -142,24 +145,27 @@ export function CardsChat() {
<form
onSubmit={(event) => {
event.preventDefault()
if (inputLength === 0) return
setMessages([
...messages,
{
role: "user",
content: event.currentTarget.message.value,
content: input,
},
])

event.currentTarget.message.value = ""
setInput("")
}}
className="flex w-full items-center space-x-2"
>
<Input
id="message"
placeholder="Type your message..."
className="flex-1"
autoComplete="off"
value={input}
onChange={(event) => setInput(event.target.value)}
/>
<Button type="submit" size="icon">
<Button type="submit" size="icon" disabled={inputLength === 0}>
<Send className="h-4 w-4" />
<span className="sr-only">Send</span>
</Button>
Expand Down
13 changes: 9 additions & 4 deletions apps/www/registry/new-york/example/cards/chat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export function CardsChat() {
content: "I can't log in.",
},
])
const [input, setInput] = React.useState("")
const inputLength = input.trim().length

return (
<>
Expand Down Expand Up @@ -143,24 +145,27 @@ export function CardsChat() {
<form
onSubmit={(event) => {
event.preventDefault()
if (inputLength === 0) return
setMessages([
...messages,
{
role: "user",
content: event.currentTarget.message.value,
content: input,
},
])

event.currentTarget.message.value = ""
setInput("")
}}
className="flex w-full items-center space-x-2"
>
<Input
id="message"
placeholder="Type your message..."
className="flex-1"
autoComplete="off"
value={input}
onChange={(event) => setInput(event.target.value)}
/>
<Button type="submit" size="icon">
<Button type="submit" size="icon" disabled={inputLength === 0}>
<PaperPlaneIcon className="h-4 w-4" />
<span className="sr-only">Send</span>
</Button>
Expand Down