Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace :has with flexbox in the alert component #998 #1031

Closed
wants to merge 1 commit into from
Closed

replace :has with flexbox in the alert component #998 #1031

wants to merge 1 commit into from

Conversation

obenchkroune
Copy link

No description provided.

@shadcn
Copy link
Collaborator

shadcn commented Aug 4, 2023

@obenchkroune I merged a fix for this in #1059. What are your thoughts on this approach?

@shadcn shadcn added bug Something isn't working component: alert labels Aug 4, 2023
@obenchkroune
Copy link
Author

@shadcn i think #1059 is much better to address the lack of "has" support in firefox without changing the way alerts are already styled, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working component: alert
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenchkroune @shadcn