Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timezones no longer supported by Debian #584

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

billdenney
Copy link
Collaborator

fix #582
fix #583 (rather than removing it, I warned about using timezones-- let the user make a choice)

@billdenney billdenney linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (709b2ab) to head (16aa4e1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #584   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1401      1406    +5     
=========================================
+ Hits          1401      1406    +5     
Files with missing lines Coverage Δ
R/sas_dates.R 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

Copy link
Owner

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion and a question based on our discussion in #583

R/sas_dates.R Outdated Show resolved Hide resolved
R/sas_dates.R Outdated Show resolved Hide resolved
billdenney and others added 2 commits November 19, 2024 12:24
Co-authored-by: Sam Firke <[email protected]>
… for recent change; clarify minor breaking change for `sas_numeric_to_date()`
@sfirke sfirke merged commit 74345da into main Nov 19, 2024
10 checks passed
@sfirke sfirke deleted the 582-submit-to-cran-to-fix-debian-check-failure branch November 19, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove timezone support from sas_numeric_to_date() Submit to CRAN to fix Debian check failure
2 participants