2992_Core_mapping_the_created_items_are_disapeared_after_logout_gameplay #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2992 |
IanMayo
reviewed
Jul 9, 2024
| } else { | ||
| theChannel.messages.unshift(newObj) | ||
| } | ||
| theChannel.messages.push(newObj) |
There was a problem hiding this comment.
Hello @lilitkarapetyan - I'm nervous about the impact of this change across all of the channels that use this logic. Could you check please new messages get added properly to each type of channel (including mapping).
Actually, @Tristina1788 - it could do with a good test from you too, please. We need to check messages are shown in the correct order in all channel types, and that new messages are correctly shown. This should also include changes to message in a Collab channel.
2024-07-09_17-42-03.mp4
So, I think the fixing is working fine. |
IanMayo
approved these changes
Jul 9, 2024
IanMayo
deleted the
2992_Core_mapping_the_created_items_are_disapeared_after_logout_gameplay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Issue
🚀 Overview:
🔗 Link to preview
🤔 Reason:
🔨Work carried out:
🖥️ Screenshot
Confirmations
📝 Developer Notes: