Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2892_Edit_templates_in_admin_pages #2897

Open
wants to merge 192 commits into
base: develop
Choose a base branch
from

Conversation

lilitkarapetyan
Copy link
Collaborator

@lilitkarapetyan lilitkarapetyan commented Mar 6, 2024

NOTE: Converted to draft, since we can only merge it once we've fully moved to the new template model.

Fixes #2892

🧰 Issue

🚀 Overview:

🔗 Link to preview

🤔 Reason:

🔨Work carried out:

  • Tests pass

🖥️ Screenshot

Confirmations

  • I have chosen reviewers for my PR.
  • I have assigned myself to this PR.
  • I have chosen an appropriate label for the PR.
  • I have completed the mandatory sections of this document.
  • I have deleted any unused sections.
  • I confirm that I have checked for required README updates and acted accordingly.

📝 Developer Notes:

@lilitkarapetyan lilitkarapetyan added the 4p10 Potential to support P10 label Mar 6, 2024
@lilitkarapetyan lilitkarapetyan requested a review from IanMayo as a code owner March 6, 2024 06:30
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 06:30 Inactive
@lilitkarapetyan
Copy link
Collaborator Author

fixes #2892

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 06:35 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 06:54 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 07:19 Inactive
@Tristina1788
Copy link
Collaborator

@IanMayo , @lilitkarapetyan Tested on '2892_Edit_templates_in_admin_pages' , Now I can see the new tab 'Template' for wargame

image

But I see some issues on this feature :

  • Can't rename a template which has created
unable-to-rename-new-template.mp4
  • Message for duplicate template is incorrect

image

  • Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it)

image

  • Text 'CREATE TEMPLATE LIST' is incorrect

image

  • It shows white screen when delete all template name
white-screen-delete-template-name.mp4

@lilitkarapetyan
Copy link
Collaborator Author

@IanMayo , @lilitkarapetyan Tested on '2892_Edit_templates_in_admin_pages' , Now I can see the new tab 'Template' for wargame

image

But I see some issues on this feature :

* Can't rename a template which has created

unable-to-rename-new-template.mp4

* Message for duplicate template is incorrect

image

* Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it)

image

* Text 'CREATE TEMPLATE LIST' is incorrect

image

* It shows white screen when delete all template name

white-screen-delete-template-name.mp4

Hello @Tristina1788 , I appreciate your input. I will definitly look into it and improve it. Thank you

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 09:14 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 09:50 Inactive
@IanMayo
Copy link
Contributor

IanMayo commented Mar 6, 2024

Hello @Tristina1788 , I appreciate your input. I will definitly look into it and improve it. Thank you

You're right @lilitkarapetyan - that's great feedback @Tristina1788

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 6, 2024 10:43 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 7, 2024 06:23 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-bbryg4 March 7, 2024 06:37 Inactive
@Tristina1788
Copy link
Collaborator

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

  • Text 'CREATE TEMPLATE LIST' is correct

image

  • Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

@lilitkarapetyan
Copy link
Collaborator Author

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

image

* Enable to rename a template which has created

@Lil

Tested on '2892_Edit_templates_in_admin_pages'

Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

image

* Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

Hello @Tristina1788 Please shere the details of the issue, and I'll be more then happy to assist you.

@Tristina1788
Copy link
Collaborator

Tested on '2892_Edit_templates_in_admin_pages'
Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

image

* Enable to rename a template which has created

@Lil

Tested on '2892_Edit_templates_in_admin_pages'
Above issues are still happened. Only some issues are fixed as below

* Text 'CREATE TEMPLATE LIST' is correct

image

* Enable to rename a template which has created

@lilitkarapetyan Please help to fix another issues

Hello @Tristina1788 Please shere the details of the issue, and I'll be more then happy to assist you.

Hi @lilitkarapetyan , I mean these issue are still happened.

  • Message for duplicate template is incorrect. It should be 'Template is duplicated'

image

  • Create/Rename a template and it shows incorrect message. (only one template is saved, not multiple templates. So we should update it) => It should be 'Template is saved'

image

  • Delete all name of template make a full white screen. We need to refresh to go to admin page again.
white-screen-delete-template-name.mp4

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 8, 2024 08:34 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 8, 2024 09:00 Inactive
@Tristina1788
Copy link
Collaborator

Tristina1788 commented Aug 8, 2024

@lilitkarapetyan @IanMayo

  • The multi rows fields show difference from 'Preview Form' (Max default fields on row is 7) and game play (Max default fields on row is 7)
    image

image

  • The 'Send Message' and input fields should has space

image

  • I think the default should be each field on one line ( I mean default size can be 11 or 12 instead of 1.5 as current )

  • Detail message of Blue WA channel is quite hard to see. I think it's better with original detail on develop branch

image

image

  • Template with form element and section shows not good (Example : 'Wa Message' template)

image

image

image

  • Get erros on 2 pages on story book (It's not happened on 'develop' branch)

http://localhost:6611/?path=/story/local-collabstatusboard--collaborative-edit-editor
http://localhost:6611/?path=/story/local-organisms-coremapping--default

image

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 8, 2024 09:32 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 9, 2024 06:55 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 9, 2024 08:35 Inactive
@Tristina1788
Copy link
Collaborator

@lilitkarapetyan @IanMayo
Template with form element and section shows not good (Example : 'Wa Message' template, from the 'Visual Form Build' , Id and Weapon are above section Threat, but from 'Preview Form' and Game Play, Id and Weapon are below section Threat )

image

image

image

  • 'Send Message' and 'Cancel' are in wrong position and the sizes of buttons are not good

image

  • Description field makes the next field move to right

image

image

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 9, 2024 09:57 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 9, 2024 10:27 Inactive
@Tristina1788
Copy link
Collaborator

  • Template with form element and section shows well now

image

  • 'Description field makes the next field move to right' => It's fixed as expected

image

  • 'Send Message' and 'Cancel' are in correct position. But I think it's better to have a little space with scoll bar

image

I'm checking more.

@Tristina1788
Copy link
Collaborator

Tristina1788 commented Aug 10, 2024

@lilitkarapetyan @IanMayo

  • Description of checkbox is not showed in 'Preview Form' and GamePlay

image

image

image

  • Detail of sent message should show by Display Name instead of Object Name

image

image

  • Button action of Item in Array field still show not good when it has description. Action button should align with input row

image

image

  • Error message for field makes the next field move to right

image

image

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 12, 2024 08:00 Inactive
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 12, 2024 08:50 Inactive
@lilitkarapetyan
Copy link
Collaborator Author

  • Template with form element and section shows well now

image

* 'Description field makes the next field move to right' => It's fixed as expected

image

* 'Send Message' and 'Cancel' are in correct position. But I think it's better to have a little space with scoll bar

image

I'm checking more.

In that case, we neeed to make the Display Name and Object Name the same.

@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-7zrz16 August 12, 2024 09:14 Inactive
@IanMayo IanMayo marked this pull request as ready for review September 17, 2024 13:36
@IanMayo IanMayo temporarily deployed to serge-2892-edit-templat-0cbgol September 17, 2024 13:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4p10 Potential to support P10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit templates in admin pages
3 participants