Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inspect validation #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added inspect validation #82

wants to merge 2 commits into from

Conversation

munishchouhan
Copy link
Member

This PR Will add validation for the inspect option to have a compulsory container image

Signed-off-by: munishchouhan <[email protected]>
@munishchouhan munishchouhan self-assigned this Oct 16, 2024
@munishchouhan munishchouhan marked this pull request as draft October 16, 2024 05:55
Signed-off-by: munishchouhan <[email protected]>
@munishchouhan
Copy link
Member Author

% ./app/build/native/nativeCompile/wave --conda-package bwa --freeze --singularity --inspect
Option --inspect requires the use of container image (--image)

@munishchouhan munishchouhan marked this pull request as ready for review October 17, 2024 12:18
@@ -241,6 +241,8 @@ else if( result.isVersionHelpRequested() ) {

app.setLogLevel();
app.defaultArgs();
// validate the command line args
app.validateArgs();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inspect is running before this validation so either i can validate it in inspect method or move validate method before inspect method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants