Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets policies #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

llewellyn-sl
Copy link
Contributor

@llewellyn-sl llewellyn-sl commented Jun 5, 2023

Add 3 permissions policies for AWS Secrets Manager:

  • Tower instance role
  • ECS execution role
  • ECS IAM trust relationship
  • EC2 custom role
  • EC2 custom trust policy

These policies are added to align with Tower docs updates in https://github.com/seqeralabs/nf-tower-docs/pull/350

The necessity to delete the existing secrets policies in this repo is to be determined.

@llewellyn-sl llewellyn-sl marked this pull request as draft June 5, 2023 13:45
Copy link

@gwright99 gwright99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm losing track of what's going on. Approving this so the files are all in the same repo. We can take a second pass to figure out if any of the related prose on the Secrets page needs to change afterwards.

@llewellyn-sl
Copy link
Contributor Author

I'm losing track of what's going on. Approving this so the files are all in the same repo. We can take a second pass to figure out if any of the related prose on the Secrets page needs to change afterwards.

There is no prose in this PR. This is just to add your new secrets policies (related to the secrets updates docs PR in Cloud)

@llewellyn-sl llewellyn-sl marked this pull request as ready for review June 20, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants