Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make simhash compatible with Python>=3.9 #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HYLcool
Copy link

@HYLcool HYLcool commented May 15, 2023

In Python>=3.8, the field tp_print is renamed as tp_vectorcall_offset(ref). So, when install simhash-py under Python 3.9 or later, an error would occur during building like below:

simhash/simhash.cpp:2112:73: error: no member named 'tp_print' in '_typeobject'

To make simhash compatible with Python>=3.9, I add a version check when applying assignment to this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant