Enhance service store management #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor `get_store` function to support additional store types: DuckDB and Parquet. - Introduce `ServiceInput` model for service creation and updates. - Modify `ServicesStore` interface to return `None` for non-existent services. - Implement `update_service` method in `LocalStore` for service updates. - Add base class `DuckDBBaseStore` for DuckDB-based service storage. - Improve test fixtures for parameterized store types. + some auth improvements - Update `validate` method in `FakeBasicAuth` to handle missing authorization headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #34
get_storefunction to support additional store types: DuckDB and Parquet.ServiceInputmodel for service creation and updates.ServicesStoreinterface to returnNonefor non-existent services.update_servicemethod inLocalStorefor service updates.DuckDBBaseStorefor DuckDB-based service storage.some auth improvements
validatemethod inFakeBasicAuthto handle missing authorization headers.