Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AbstractSentinelHubV3Layer to receive evalscript value from dataProduct endpoint #278

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Change AbstractSentinelHubV3Layer to receive evalscript value from dataProduct endpoint #278

merged 1 commit into from
Sep 9, 2024

Conversation

janybravo
Copy link

@janybravo janybravo commented Sep 4, 2024 •
edited
Loading

@janybravo janybravo self-assigned this Sep 4, 2024
@zcernigoj zcernigoj self-requested a review September 5, 2024 12:19
zcernigoj
zcernigoj requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@zcernigoj zcernigoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a release candidate version can already be created and a MR prepared in EO Browser repository with this new release candidate version.

@janybravo janybravo requested a review from zcernigoj September 6, 2024 07:42
@janybravo janybravo force-pushed the change-user-instances-layers-to-use-processing branch from 37f09c0 to 89e7ff7 Compare September 6, 2024 07:44
zcernigoj
zcernigoj requested changes Sep 6, 2024
View reviewed changes
src/layer/AbstractSentinelHubV3Layer.ts Outdated Show resolved Hide resolved
@janybravo janybravo force-pushed the change-user-instances-layers-to-use-processing branch 4 times, most recently from bb5e948 to 74b3446 Compare September 6, 2024 13:06
@janybravo janybravo requested a review from zcernigoj September 6, 2024 13:22
zcernigoj
zcernigoj requested changes Sep 9, 2024
View reviewed changes
src/layer/AbstractSentinelHubV3Layer.ts Outdated Show resolved Hide resolved
Change layers with dataProduct to fetch tiles from processing api
2ece839 
with exception of datasets/S2L1C/dataproducts/643
@janybravo janybravo force-pushed the change-user-instances-layers-to-use-processing branch from 74b3446 to 2ece839 Compare September 9, 2024 12:20
@janybravo janybravo requested a review from zcernigoj September 9, 2024 12:26
zcernigoj
zcernigoj approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@zcernigoj zcernigoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@janybravo janybravo merged commit 8ed8f23 into master Sep 9, 2024
2 checks passed
@janybravo janybravo deleted the change-user-instances-layers-to-use-processing branch September 9, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcernigoj zcernigoj zcernigoj approved these changes

Assignees

@janybravo janybravo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janybravo @zcernigoj