Fix bug with 404 on GET request for batch_request #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigaLuksic
approved these changes
Nov 6, 2024
Merged
zigaLuksic
added a commit
that referenced
this pull request
Nov 6, 2024
* prepare changelog and increase version * update hooks * Fix bug with 404 on GET request for batch_request (#356) * add a retry wrapper around the GET request * make mypy happy * add intermediate value --------- Co-authored-by: Matic Lubej <[email protected]> Co-authored-by: Ziga Luksic <[email protected]> --------- Co-authored-by: Matic Lubej <[email protected]> Co-authored-by: Matic Lubej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is that SH has separate read/write databases which can be out of sync. Adds a wrapper for retrying on 404 around the GET request as well
Let me know if you want to name them differently