Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Calls SDK v1.12.1 #4

Closed
wants to merge 6 commits into from
Closed

Update Calls SDK v1.12.1 #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46bf571
update google.android.flexbox
TeddyChoe Jan 20, 2025
6a281e9
update calls sdk version and kotlin version, targetSDK.
TeddyChoe Jan 20, 2025
28474d1
update gradle, kotlin and android-gradle-plugin version
TeddyChoe Jan 24, 2025
1223129
upgrade target sdk to 35. checked intent-filter, permission. this app…
TeddyChoe Feb 3, 2025
24a8023
upgrade kotlin version. and replace deprecated method.
TeddyChoe Feb 3, 2025
16793f4
update gradle version and android gradle plugin version.
TeddyChoe Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ plugins {
}

android {
compileSdkVersion 30
compileSdkVersion 33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것도 34로 최신 되나요~? 35도 될라나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calls sdk랑 버전을 맞춰야할 것 같아 33으로 맞췄습니다! 34나 35로 올리면 여기서 실행되는 SDK의 targetSDK도 같이 올라가서 되도록이면 calls sdk 버전과 맞추는게 어떨까 싶습니다!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요게 샘플이라 고객들 기준으로 보는게 좋을 것 같아서요. 고객들은 최신 버전에서 사용하는 케이스가 많을테니 문제 없으면 올리는게 좋을 것 같아요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다! 1223129

buildToolsVersion "30.0.1"

defaultConfig {
applicationId "com.sendbird.calls.quickstart.groupcall"
minSdkVersion 21
targetSdkVersion 30
targetSdkVersion 33
versionCode 1
versionName "1.0.0"

Expand Down Expand Up @@ -44,10 +44,10 @@ dependencies {
implementation 'androidx.appcompat:appcompat:1.2.0'
implementation 'com.google.android.material:material:1.3.0'
implementation 'androidx.constraintlayout:constraintlayout:2.0.4'
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0'

// Sendbird Calls
implementation 'com.sendbird.sdk:sendbird-calls:1.6.0'
implementation 'com.sendbird.sdk:sendbird-calls:1.12.1'

// Glide
implementation 'com.github.bumptech.glide:glide:4.12.0'
Expand All @@ -63,7 +63,7 @@ dependencies {
implementation "androidx.camera:camera-view:1.0.0-alpha23"

// FlexBox
implementation 'com.google.android:flexbox:2.0.1'
implementation 'com.google.android.flexbox:flexbox:3.0.0'

annotationProcessor 'com.github.bumptech.glide:compiler:4.12.0'

Expand Down
3 changes: 2 additions & 1 deletion app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
android:theme="@style/Theme.MaterialComponents.Light.NoActionBar" />
<activity
android:name="com.sendbird.calls.quickstart.groupcall.splash.SplashActivity"
android:theme="@style/Theme.MaterialComponents.Light.NoActionBar">
android:theme="@style/Theme.MaterialComponents.Light.NoActionBar"
android:exported="true">
<intent-filter>
<action android:name="android.intent.action.MAIN" />

Expand Down
37 changes: 37 additions & 0 deletions app/src/main/java/com/sendbird/calls/quickstart/groupcall/room/GroupCallViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,50 @@ class GroupCallViewModel(
_currentAudioDevice.postValue(currentAudioDevice)
}

override fun onCustomItemsDeleted(deletedKeys: List<String>) {
Log.d(TAG, "onCustomItemsDeleted() called with: deletedKeys = $deletedKeys")
}

override fun onCustomItemsUpdated(updatedKeys: List<String>) {
Log.d(TAG, "onCustomItemsUpdated() called with: updated = $updatedKeys")
}

override fun onDeleted() {
Log.d(TAG, "onDeleted() called")
}

override fun onError(e: SendBirdException, participant: Participant?) {
Log.d(TAG, "onError() called with: e = $e, participant = $participant")
if (e.code == SendBirdError.ERR_LOCAL_PARTICIPANT_LOST_CONNECTION) {
// reconnection failed.
}
}

override fun onInvitationAccepted(roomInvitation: RoomInvitation) {
Log.d(TAG, "onInvitationAccepted() called with: roomInvitation = $roomInvitation")
_participants.postValue(sortedParticipants)
}

override fun onInvitationCanceled(roomInvitation: RoomInvitation) {
Log.d(TAG, "onInvitationCanceled() called with: roomInvitation = $roomInvitation")
_participants.postValue(sortedParticipants)
}

override fun onInvitationDeclined(roomInvitation: RoomInvitation) {
Log.d(TAG, "onInvitationDeclined() called with: roomInvitation = $roomInvitation")
_participants.postValue(sortedParticipants)
}

override fun onLocalParticipantDisconnected(participant: LocalParticipant) {
Log.d(TAG, "onLocalParticipantDisconnected() called with: participant = $participant")
_participants.postValue(sortedParticipants)
}

override fun onLocalParticipantReconnected(participant: LocalParticipant) {
Log.d(TAG, "onLocalParticipantReconnected() called with: participant = $participant")
_participants.postValue(sortedParticipants)
}

override fun onRemoteAudioSettingsChanged(participant: RemoteParticipant) {
Log.d(TAG, "onRemoteAudioSettingsChanged() called with: participant = $participant")
_participants.postValue(_participants.value)
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext.kotlin_version = "1.4.31"
ext.kotlin_version = "1.6.10"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코틀린도 더 올릴 수 있으면 올리시죠!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kotlin version도 1.9.21로 올렸는데 최신은 아니고 kapt plugin이라는 현 샘플앱에서 사용하는 plugin이 동작하는 최소 버전으로 올렸습니다 28474d1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최신으로 수정했습니다! 24a8023

ext.nav_version = "2.3.4"
ext.camerax_version = "1.0.0-rc03"
repositories {
google()
mavenCentral()
}
dependencies {
classpath "com.android.tools.build:gradle:4.1.2"
classpath "com.android.tools.build:gradle:7.4.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요것도 되면!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옙 요거 8.1.2로 올렸는데 최신은 아니고 calls sdk랑 버전 같도록 올렸습니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle version과 같이 올렸습니다! 16793f4

classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:$nav_version"

Expand Down
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Tue Mar 30 10:50:26 KST 2021
#Mon Jan 20 15:39:40 KST 2025
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가장 최신으로 올리면 문제되나요?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최신으로 올리면 아마 다른 라이브러리들도 같이 올려야할텐데요, 최대한 calls sdk랑 버전이 차이나지 않는게 좋을 것 같아 8.5 정도로 올렸습니다. 8.5는 현재 버전의 Android Studio가 빌드할 때 필요한 최소 버전입니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 android studio에서 가이드하는 버전으로 올렸습니다. 8.10.2로 더 올릴 수는 있는데 stable하게 쓰려면 studio에서 제안하는 버전으로 올리는게 좋을 것 같았어요.(8.9도 거의 최신 버전이라 이 정도도 괜찮지 않을까 싶어요!) 16793f4
gradle version 문서

zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-bin.zip