fix: no pro finding for raw-html-concat.js:18 #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not expect a pro finding here since the tainted `newContent` is not in scope, so this actually throws `ReferenceError`. See also discussion on SAF-1013.
neuroo
approved these changes
Aug 27, 2024
|
Hmm looks like we may only allow |
Apparently we only support deepok second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not expect a pro finding here since the tainted
newContentis not in scope, so this actually throwsReferenceError. See also discussion on SAF-1013.Cf. a version written with
var, where hoisting would mean thatnewContentwould be in scope, and the test should generate a finding.