Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate globby to tinyglobby #938

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ziebam
Copy link

@ziebam ziebam commented Oct 5, 2024

This PR is a suggestion to replace globby with tinyglobby – a lighter alternative with less transitive dependencies.

);
return [];
}

const globbed = await globby(glob, {
cwd,
expandDirectories: false, // TODO Temporary workaround for https://github.com/mrmlnc/fast-glob/issues/47
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue doesn't happen with tinyglobby, so we don't need to disable expanding directories.

onlyFiles: false,
})
).map((result) =>
result.endsWith("/") ? result.slice(0, -1) : result
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stems from the way tinyglobby returns the results:
366205111-4bfd55b6-014d-4781-b7d8-fbe6776228b4

In case returning a trailing slash wouldn't break users, and you decide to go forward with this migration, I'm open to updating the tests instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant