Use FileOutputStreamWriter to store screenshot files

selinanatschke-mms · Sep 19, 2024 · 7fb3570 · 7fb3570
1 parent c034bd1
commit 7fb3570
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/utils/UITestUtils.java b/driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/utils/UITestUtils.java
@@ -45,8 +45,8 @@
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.OutputStream;
 import java.io.OutputStreamWriter;
-import java.nio.file.Files;
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.Collection;
@@ -227,9 +227,12 @@ public static void takeWebDriverScreenshotToFile(WebDriver decoratedWebDriver, F
     }
 
     private static void makeSimpleScreenshot(WebDriver driver, File screenShotTargetFile) {
-        try {
-            File file = ((TakesScreenshot) driver).getScreenshotAs(OutputType.FILE);
-            FileUtils.moveFile(file, screenShotTargetFile);
+        // Using FileOutputStream prevents from file permission issues on -ix systems:
+        // '((TakesScreenshot) driver).getScreenshotAs(OutputType.FILE)' creates files with user-only permissions
+        // Moving the file with latest org.apache.commons.io.FileUtils does not change permissions any more
+        try (OutputStream os = new FileOutputStream(screenShotTargetFile)) {
+            byte[] screenshot = ((TakesScreenshot) driver).getScreenshotAs(OutputType.BYTES);
+            os.write(screenshot);
         } catch (Exception e) {
             LOGGER.error("Unable to take screenshot to file", e);
         }
@@ -238,7 +241,7 @@ private static void makeSimpleScreenshot(WebDriver driver, File screenShotTarget
     /**
      * Save page source to file.
      *
-     * @param pageSource page source.
+     * @param pageSource       page source.
      * @param sourceTargetFile target file.
      */
     private static void savePageSource(final String pageSource, final File sourceTargetFile) {

diff --git a/integration-tests/src/main/java/eu/tsystems/mms/tic/testframework/AbstractTestSitesTest.java b/integration-tests/src/main/java/eu/tsystems/mms/tic/testframework/AbstractTestSitesTest.java
@@ -45,7 +45,7 @@ protected TestPage getTestPage() {
     @BeforeTest(alwaysRun = true)
     public void setUp() throws Exception {
         try {
-            staticServer.start(80);
+            staticServer.start(8080);
         } catch (BindException e) {
             log().warn("Use already running WebServer: " + e.getMessage());
         }

diff --git a/...ests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverStandaloneTest.java b/...ests/src/test/java/eu/tsystems/mms/tic/testframework/playground/DriverStandaloneTest.java
@@ -24,14 +24,14 @@ public class DriverStandaloneTest extends AbstractWebDriverTest {
     public void testFailing() throws Exception {
         DesktopWebDriverRequest request = new DesktopWebDriverRequest();
         request.setBaseUrl("http://google.de");
-        request.setBrowser(Browsers.chrome);
+//        request.setBrowser(Browsers.chrome);
 
         WebDriver webDriver = WEB_DRIVER_MANAGER.getWebDriver(request);
-        UITestUtils.takeScreenshot(webDriver, false);
+        UITestUtils.takeScreenshot(webDriver, true);
 //        Assert.assertTrue(false);
-        File file = ((TakesScreenshot) webDriver).getScreenshotAs(OutputType.FILE);
-        PosixFileAttributeView fileAttributeView = Files.getFileAttributeView(file.toPath(), PosixFileAttributeView.class);
-        log().info("take screenshot src {}", file.toPath());
+//        File file = ((TakesScreenshot) webDriver).getScreenshotAs(OutputType.FILE);
+//        PosixFileAttributeView fileAttributeView = Files.getFileAttributeView(file.toPath(), PosixFileAttributeView.class);
+//        log().info("take screenshot src {}", file.toPath());
 //        log().info("Posix {}", fileAttributeView.readAttributes().permissions().toString());
     }