Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::unordered_map instead of std::map #1285

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

tigercosmos
Copy link
Collaborator

part of #977

changed std::map to std::unordered_map

there are a few cases that still keep using std::map due to the original intention usage of the std::map properties.

@tigercosmos tigercosmos changed the title Use std::unordered_map instead of std::map WIP:Use std::unordered_map instead of std::map Jan 23, 2024
@tigercosmos tigercosmos changed the title WIP:Use std::unordered_map instead of std::map WIP: Use std::unordered_map instead of std::map Jan 23, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4893499) 82.42% compared to head (58234a0) 82.42%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1285   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         161      161           
  Lines       20764    20764           
  Branches     7846     7854    +8     
=======================================
  Hits        17115    17115           
+ Misses       2993     2987    -6     
- Partials      656      662    +6     
Flag Coverage Δ
alpine317 72.14% <66.66%> (-0.05%) ⬇️
centos7 74.35% <100.00%> (+0.01%) ⬆️
fedora37 72.10% <66.66%> (-0.11%) ⬇️
macos-11 61.13% <100.00%> (-0.01%) ⬇️
macos-12 61.18% <100.00%> (-0.01%) ⬇️
mingw32 69.98% <66.66%> (-0.08%) ⬇️
mingw64 69.96% <66.66%> (-0.12%) ⬇️
npcap 83.17% <100.00%> (-0.05%) ⬇️
ubuntu1804 74.77% <100.00%> (-0.05%) ⬇️
ubuntu2004 72.90% <83.33%> (-0.08%) ⬇️
ubuntu2204 71.98% <66.66%> (-0.06%) ⬇️
ubuntu2204-icpx 59.12% <95.00%> (+0.04%) ⬆️
unittest 82.42% <100.00%> (ø)
windows-2019 83.21% <100.00%> (-0.02%) ⬇️
windows-2022 83.22% <100.00%> (-0.02%) ⬇️
winpcap 83.19% <100.00%> (+0.01%) ⬆️
xdp 58.64% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos tigercosmos changed the title WIP: Use std::unordered_map instead of std::map Use std::unordered_map instead of std::map Jan 24, 2024
@tigercosmos
Copy link
Collaborator Author

@seladb ready for review. the only failed case is the CI issue.

@tigercosmos
Copy link
Collaborator Author

@seladb still happens, any idea?
image

@seladb
Copy link
Owner

seladb commented Jan 26, 2024

@tigercosmos maybe you need to change the CirrusCI image to freebsd-version: "13.2"?
This is done in this PR: #1281

@tigercosmos
Copy link
Collaborator Author

@seladb should be fine now.

@seladb seladb merged commit 07a3d52 into seladb:dev Jan 30, 2024
38 checks passed
@seladb
Copy link
Owner

seladb commented Jan 30, 2024

Thank you @tigercosmos for working on this! I think we finally got rid of std::map 😄

@tigercosmos tigercosmos deleted the use_unordered_map branch January 30, 2024 08:33
fxlb pushed a commit to fxlb/PcapPlusPlus that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants