(이주연) StringCalculator 리뷰 요청드립니다. #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKiHyun0206
changed the title
KimKiHyun0206
commented
Sep 4, 2024
Comment on lines
+10
to
+23
| switch (operator) { | ||
| case "+": | ||
| currentResult += number; | ||
| break; | ||
| case "-": | ||
| currentResult -= number; | ||
| break; | ||
| case "*": | ||
| currentResult *= number; | ||
| break; | ||
| case "/": | ||
| if (number == 0) { | ||
| throw new ArithmeticException("0으로 나눌 수 없습니다."); | ||
| } |
There was a problem hiding this comment.
Enum을 사용해서 switch문을 사용하지 않는 방향으로 코드를 작성해봅시다
| currentResult /= number; | ||
| break; | ||
| default: | ||
| System.out.println("지원하지 않는 연산자입니다: " + operator); |
There was a problem hiding this comment.
Calculator 클래스의 책임은 무엇인가요.
한 클래스에 여러 개의 책임이 있는 것 같습니다.
SCP에 대해서 공부해보고 코드를 작성해주세요
Comment on lines
+2
to
+20
| public boolean isValid(String expression) { | ||
| String[] tokens = expression.split(" "); | ||
|
|
||
| if (tokens.length % 2 == 0) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!isNumeric(tokens[0])) { | ||
| return false; | ||
| } | ||
|
|
||
| for (int i = 1; i < tokens.length; i += 2) { | ||
| if (!isOperator(tokens[i]) || !isNumeric(tokens[i + 1])) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
한 메소드가 많은 역할을 해주는 것 같습니다.
각각의 if문을 여러 메소드로 나누어보세요.
There was a problem hiding this comment.
Main 클래스에 너무 많은 책임이 있습니다.
SCP에 대해서 공부 해보고 코드를 작성해주세요
- 콘솔에 프린트해주는 것도 하나의 책임으로 봅니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 요청드립니다