-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CT types #1899
base: main
Are you sure you want to change the base?
CT types #1899
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 61.37% 61.21% -0.17%
==========================================
Files 263 264 +1
Lines 23314 23339 +25
==========================================
- Hits 14310 14287 -23
- Misses 7995 8042 +47
- Partials 1009 1010 +1
|
This LGTM so far, to summarize my understanding here:
Does this sound right? Questions:
|
) | ||
|
||
func TestMsgTransfer_FromProto(t *testing.T) { | ||
testDenon := "factory/sei1ft98au55a24vnu9tvd92cz09pzcfqkm5vlx99w/TEST" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testDenom*
|
||
remainingBalance := uint64(200) | ||
|
||
// Encrypt the amount using source and destination public keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to make this its own function?
func ToProto(transfer *Transfer) *MsgTransfer {}
Describe your changes and provide context
Ciphertext dto for ct
Testing performed to validate your change