-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STRATCONN-4282] Braze validation and multi-status fix #2521
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2521 +/- ##
==========================================
- Coverage 78.78% 78.00% -0.79%
==========================================
Files 1052 991 -61
Lines 20503 17388 -3115
Branches 4228 3281 -947
==========================================
- Hits 16153 13563 -2590
+ Misses 3256 2737 -519
+ Partials 1094 1088 -6 ☔ View full report in Codecov by Sentry. |
packages/destination-actions/src/destinations/braze/__tests__/multistatus.test.ts
Outdated
Show resolved
Hide resolved
@@ -179,7 +184,7 @@ export async function sendBatchedTrackEvent( | |||
}) | |||
|
|||
await handleBrazeAPIResponse( | |||
transformPayloadsType(payloads), | |||
payloads as object as JSONLikeObject[], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems stylistic. How risky is it? Should we leave it out to reduce the number of variables we're changing in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply a type definition. The transformPayloadsType function was previously used only to change the type. However, since type information is removed during the compilation from TypeScript to JavaScript, this would result in an extra, non-functional function being left behind.
cab2fe9
to
211d60c
Compare
Context
Earlier Braze required on the the 3 fields to be present to be considered an event to be valid, they were
braze_id
,user_alias
andexternal_id
. Lateremail
was added, however this validation was missing from the MultiStatus flow.PR Contents
sent
was to the original batch payload instead of what was actually sent.Testing
Testes locally.