Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iterable Lists] Adding logic to not create an audience if an existing audience already exists with the same name. #2511

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

seg-leonelsanches
Copy link
Contributor

After testing Iterable Lists destination with the customer, we found out that the audience lifecycle tries to create an audience more than once, which it generates errors on Iterable, preventing the audience to sync correctly.

Here I add logic to first verify whether the corresponding list already exists. If it exists, the logic returns its id.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@seg-leonelsanches seg-leonelsanches marked this pull request as ready for review October 21, 2024 17:26
@seg-leonelsanches seg-leonelsanches requested a review from a team as a code owner October 21, 2024 17:26
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (2574714) to head (240a9fe).

Files with missing lines Patch % Lines
...n-actions/src/destinations/iterable-lists/index.ts 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2511   +/-   ##
=======================================
  Coverage   77.99%   78.00%           
=======================================
  Files         991      991           
  Lines       17383    17390    +7     
  Branches     3281     3283    +2     
=======================================
+ Hits        13558    13565    +7     
  Misses       2737     2737           
  Partials     1088     1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants