Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Klaviyo Actions] | Added MultiStatus Batch Support on TrackEvent #2498

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Oct 10, 2024

Jira Ticket
This pull request aims to add batch support for the TrackEvent action in Klaviyo(Actions). Additionally, this PR includes the validation and conversion of phone numbers to E164 format for TrackEvent, as there is a separate PR (#2481) currently under review. These changes are essential and should be included.

Local & Stage Testing Documentation

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Innovative-GauravKochar Innovative-GauravKochar changed the title Added trackEvent Batch Support in Klaviyo [Klaviyo Actions] | Added MultiStatus Batch Support on TrackEvent Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (1f43695) to head (5375521).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...tion-actions/src/destinations/klaviyo/functions.ts 78.43% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
- Coverage   78.45%   78.01%   -0.44%     
==========================================
  Files        1044      991      -53     
  Lines       19945    17436    -2509     
  Branches     4003     3292     -711     
==========================================
- Hits        15647    13602    -2045     
+ Misses       3204     2740     -464     
  Partials     1094     1094              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review October 11, 2024 13:31
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner October 11, 2024 13:31
Copy link
Contributor

@sayan-das-in sayan-das-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change. The core MultiStatus logic looks good, however I have left some review comments mostly to refactor and simplify the code as these will be listed as examples for external contributors.

As the changes are related to refactoring, please test it once again via unit tests, local and staging after committing the changes just to be sure it doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants