Salesforce custom object external

[seg-leonelsanches]

This modification:

• Updates Salesforce base API from version v53 to v62;
• Adds a new mapping to upsert a custom object by its Id.

Testing

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [Segmenters] Tested in the staging environment
• [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[joe-ayoub-segment]

hi @brennan - This is a Salesforce PR raised by an SA, so passing this PR on to you so it can be triaged.

[github-actions]

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

• Destination: Salesforce (Actions), Action Field(s):operation,customObjectName,externalIdField,externalIdValue

Add these new fields as optional instead and assume default values in perform or performBatch block.

[codecov]

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (2574714) to head (487f516).

Files with missing lines	Patch %	Lines
...nations/salesforce/customObjectExternalId/index.ts	75.00%	2 Missing ⚠️
.../src/destinations/dynamic-yield-audiences/index.ts	0.00%	1 Missing ⚠️
.../destinations/loops/createOrUpdateContact/index.ts	80.00%	1 Missing ⚠️
...tions/src/destinations/salesforce/sf-operations.ts	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage   77.99%   78.00%           
=======================================
  Files         991      992    +1     
  Lines       17383    17394   +11     
  Branches     3281     3281           
=======================================
+ Hits        13558    13568   +10     
- Misses       2737     2738    +1     
  Partials     1088     1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rvadera12]

Left a couple of comments. Can we also clean up the PR to only include the changes you made and not other syntax changes from other destinations.

Could you also include a testing doc or provide proof of the tests you ran to verify

[rvadera12]

Is there a reason why we are not implementing a performBatch method here?

[seg-leonelsanches]

@rvadera12 The batch doesn't make sense for this endpoint. Each record requires one separate API call. The API endpoint format is /services/data/v61.0/sobjects/${entityType}/${entityKey}/${entityKeyValue}. There's no way we can aggregate N records in 1 API call.