Skip to content

Commit

Permalink
Upgrade google api version to v17 (#2322)
Browse files Browse the repository at this point in the history
  • Loading branch information
@harsh-joshi99
harsh-joshi99 authored Sep 3, 2024
1 parent b48a802 commit a553da7
Show file tree
Hide file tree
Showing 12 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion ...tination-actions/src/destinations/google-enhanced-conversions/__tests__/functions.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('.getConversionActionId', () => {
}
}
nock(`https://googleads.googleapis.com`)
.post(`/v15/customers/${settings.customerId}/googleAds:searchStream`)
.post(`/v17/customers/${settings.customerId}/googleAds:searchStream`)
.reply(401, errorResponse)

const payload = {}
Expand Down
2 changes: 1 addition & 1 deletion packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { sha256SmartHash } from '@segment/actions-core'
import { RefreshTokenResponse } from '.'

export const API_VERSION = 'v15'
export const CANARY_API_VERSION = 'v15'
export const CANARY_API_VERSION = 'v17'
export const FLAGON_NAME = 'google-enhanced-canary-version'

export class GoogleAdsError extends HTTPError {
Expand Down
4 changes: 2 additions & 2 deletions ...ions/src/destinations/google-enhanced-conversions/uploadCallConversion/generated-types.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...nation-actions/src/destinations/google-enhanced-conversions/uploadCallConversion/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const action: ActionDefinition<Settings, Payload> = {
ad_user_data_consent_state: {
label: 'Ad User Data Consent State',
description:
'This represents consent for ad user data. For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad user data. For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
type: 'string',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
Expand All @@ -88,7 +88,7 @@ const action: ActionDefinition<Settings, Payload> = {
label: 'Ad Personalization Consent State',
type: 'string',
description:
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
{ label: 'DENIED', value: 'DENIED' },
Expand Down
4 changes: 2 additions & 2 deletions ...ons/src/destinations/google-enhanced-conversions/uploadCallConversion2/generated-types.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ation-actions/src/destinations/google-enhanced-conversions/uploadCallConversion2/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const action: ActionDefinition<Settings, Payload> = {
ad_user_data_consent_state: {
label: 'Ad User Data Consent State',
description:
'This represents consent for ad user data. For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad user data. For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
type: 'string',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
Expand All @@ -100,7 +100,7 @@ const action: ActionDefinition<Settings, Payload> = {
label: 'Ad Personalization Consent State',
type: 'string',
description:
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
{ label: 'DENIED', value: 'DENIED' },
Expand Down
4 changes: 2 additions & 2 deletions ...ons/src/destinations/google-enhanced-conversions/uploadClickConversion/generated-types.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...ation-actions/src/destinations/google-enhanced-conversions/uploadClickConversion/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ const action: ActionDefinition<Settings, Payload> = {
ad_user_data_consent_state: {
label: 'Ad User Data Consent State',
description:
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
type: 'string',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
Expand All @@ -214,7 +214,7 @@ const action: ActionDefinition<Settings, Payload> = {
label: 'Ad Personalization Consent State',
type: 'string',
description:
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
{ label: 'DENIED', value: 'DENIED' },
Expand Down
4 changes: 2 additions & 2 deletions ...ns/src/destinations/google-enhanced-conversions/uploadClickConversion2/generated-types.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ...tion-actions/src/destinations/google-enhanced-conversions/uploadClickConversion2/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ const action: ActionDefinition<Settings, Payload> = {
ad_user_data_consent_state: {
label: 'Ad User Data Consent State',
description:
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
type: 'string',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
Expand All @@ -221,7 +221,7 @@ const action: ActionDefinition<Settings, Payload> = {
label: 'Ad Personalization Consent State',
type: 'string',
description:
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
{ label: 'DENIED', value: 'DENIED' },
Expand Down
4 changes: 2 additions & 2 deletions ...tination-actions/src/destinations/google-enhanced-conversions/userList/generated-types.ts
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/destination-actions/src/destinations/google-enhanced-conversions/userList/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const action: ActionDefinition<Settings, Payload> = {
ad_user_data_consent_state: {
label: 'Ad User Data Consent State',
description:
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad user data.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
type: 'string',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
Expand All @@ -107,7 +107,7 @@ const action: ActionDefinition<Settings, Payload> = {
label: 'Ad Personalization Consent State',
type: 'string',
description:
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v15/Consent).',
'This represents consent for ad personalization. This can only be set for OfflineUserDataJobService and UserDataService.For more information on consent, refer to [Google Ads API Consent](https://developers.google.com/google-ads/api/rest/reference/rest/v17/Consent).',
choices: [
{ label: 'GRANTED', value: 'GRANTED' },
{ label: 'DENIED', value: 'DENIED' },
Expand Down

0 comments on commit a553da7

Please sign in to comment.