Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Admin has right to create, manage (enable, disable), and delete extended metadata types via user interface #1999 #2010

Merged
merged 26 commits into from
Oct 17, 2024
Merged

System Admin has right to create, manage (enable, disable), and delete extended metadata types via user interface #1999 #2010

merged 26 commits into from
Oct 17, 2024

Conversation

whomingbird
Copy link
Contributor

@whomingbird
System Admin has right to create, manage (enable, disable), and delet…
d4b4f24 
…e extended metadata types via user interface #1999
@whomingbird
add unit test for 'linked by metadata attributes'
d29cd98
@whomingbird
add unit tests for emt_extractor
b9c42bf 
add functional tests for extended_metadata_types_controller
@whomingbird
add test
aa553cf
@whomingbird
fix test
c07ebfe
@whomingbird
The extended metadata type can be deleted if there are no existing ex…
524f47c 
…tended metadata instances based on it.
@whomingbird
The nested extended metadata type can not be deleted if it has been l…
97b2323 
…inked by other Extended metadata types.
@whomingbird
log events for action "create" and "destroy" of extended_metadata_type
1ec24a8
@whomingbird
fix EmtExtractorTest
c981a93
@whomingbird
add "addNewMarker" after creating new extended metadata type
7b6c644
@whomingbird
add "::" operator to distinguish different ExtendedMetadataType Module
f1b37d2
@whomingbird
better javascript
8ee6b8a
@whomingbird whomingbird requested review from stuzart, abecam and fbacall and removed request for stuzart and abecam October 10, 2024 07:47
@stuzart stuzart added this to the 1.16.0 milestone Oct 11, 2024
stuzart
stuzart requested changes Oct 14, 2024
View reviewed changes
app/models/extended_metadata_type.rb Outdated Show resolved Hide resolved
app/views/extended_metadata_types/_emt_tabs.erb Outdated Show resolved Hide resolved
app/views/extended_metadata_types/_form.html.erb Outdated Show resolved Hide resolved
app/views/extended_metadata_types/_help_info.erb Outdated Show resolved Hide resolved
lib/seek/extended_metadata_type/extended_metadata_type_schema.json Outdated Show resolved Hide resolved
lib/seek/extended_metadata_type/extended_metadata_type_schema.json Outdated Show resolved Hide resolved
@whomingbird
Create the extended_metadata_supported_types method inside Seek::Util…
0647b35 
… to iterate over all models and check if they`supports_extended_metadata?`

Return the list of models that do.
@whomingbird
fix test
551ab2b
@whomingbird
use Seek::Config.instance_name and the locale's for the type names.
55e2248
@whomingbird
use the help_dictionary for help links which can be updated later
0c60ebe
@whomingbird
update style
7e52ede
@whomingbird
linked_metadata_attributes.any? and avoid looping over all the attrib…
5cb4fc4 
…ute ids
@whomingbird
ExtendedMetadata should also be a supported_type of ExtendedMetadataType
4dcefd7
@whomingbird
check programmatically that the support type supports_extended_metad…
0c65398 
…ata?
@whomingbird
rescue NameError
09f1687
@whomingbird
update json schema, remove predefined enum values for `supported_type…
168d58a 
…` and add programmatic validation
stuzart
stuzart requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@stuzart stuzart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of minor things

app/models/extended_metadata_type.rb Outdated Show resolved Hide resolved
lib/seek/util.rb Outdated Show resolved Hide resolved
lib/seek/util.rb Outdated Show resolved Hide resolved
@whomingbird whomingbird merged commit a36017d into main Oct 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuzart stuzart stuzart approved these changes

@fbacall fbacall Awaiting requested review from fbacall

Assignees
No one assigned
Labels
None yet
Projects
SEEK 1.16.x
Status: Done
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@whomingbird @stuzart