New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix facebook provider remount bug #218

Open

WayneEllery wants to merge 2 commits into seeden:master from WayneEllery:fix-facebook-provider-remount-bug

WayneEllery commented Feb 27, 2023

Fixed bug with FacebookProvider where if provider was unmounted and then remounted isReady would not be set to true so api would never be set

Also added in package-lock.json to git to ensure same version of packages are always installed

WayneEllery added 2 commits

February 28, 2023 08:23


          Remove package-lock.json from git ignore and add it

040447c

lock file should be in git to ensure same versions of packages are
always installed


          Fix: Set FacebookProvider isReady state to true when remounted

f0982f2

This bug resulted in 'Facebook API is not initialized' error

iplatonenko commented Dec 1, 2023

@seeden Hi!
Could you please merge this fix? cause it's not really possible to use actual version without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet