Store the exit message in the result for tallyvm errors #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tallyvm can run into errors outside the actual VM, while resolving host bindings for example. This leads to only the exit_info.message to be set and not the result. We write the message to the result in this scenario so it's easier for a developer to see what kind of error their program ran into. Closes: #454
gluax
approved these changes
Jan 23, 2025
hacheigriega
approved these changes
Jan 23, 2025
mariocao
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make debugging easier.
Explanation of Changes
The tallyvm can run into errors outside the actual VM, while resolving host bindings for example. This leads to only the exit_info.message to be set and not the result. We write the message to the result in this scenario so it's easier for a developer to see what kind of error their program ran into.
Testing
Added a test with a custom build WASM which references an import that does not (and should never) exist on the host.
Related PRs and Issues
Closes: #454