Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binary-analysis for migration #8

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Mihnea0Firoiu
Copy link

@Mihnea0Firoiu Mihnea0Firoiu commented Jun 22, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Update binary-analysis for migration.

@Mihnea0Firoiu Mihnea0Firoiu requested a review from teodutu June 22, 2024 14:17
@github-actions github-actions bot added area/drills Update to drills content area/infra Update to infrastructure area/reading Update to reading content topic/binary-introduction Related to the "Binary Introduction" chapter kind/improve Improve / Update existing content / item kind/new New content / item labels Jun 23, 2024
Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • At the end of each task's README.md, add a sentence like, "If you're having difficulties solving this exercise, go through [this](link to the relevant section in reading/) reading material."
  • Add the src/ folder from each task to support/ and leave the binary files at the same level as src/.

@teodutu
Copy link
Member

teodutu commented Jun 23, 2024

In addition, take a look at the failing CI/CD tests and fix them [1]. For the false positives coming from spellcheck, you'll have to add them here to the wordlists via a PR [2]. Use sort -u -o <file-name> <file-name> to keep those wordlists sorted.

[1] https://github.com/security-summer-school/essentials-security/pull/8/checks
[2] https://github.com/open-education-hub/actions/tree/main/spellcheck/config

@teodutu teodutu requested review from teodutu and Ryx076 June 28, 2024 08:39
@Mihnea0Firoiu Mihnea0Firoiu force-pushed the binary_analysis branch 6 times, most recently from 352b3ab to 0ba6abc Compare July 15, 2024 13:41
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Jul 15, 2024
Copy link

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just split the reading material into 4 parts and then this should be good to go.

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing for super-linter to pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pacify super-linter, reverse the order of the sections in this file and turn "Reminders" into a level 2 heading (##).

Copy link
Member

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the C code files were also flagging super-linter [1]. First rebase the main branch because I added a config file for cpplint which will eliminate some of the errors. Then fix the remaining ones.

[1] https://github.com/security-summer-school/essentials-security/actions/runs/9974980826/job/27563650264?pr=8#step:3:625

@Mihnea0Firoiu
Copy link
Author

I didn't see the C code files were also flagging super-linter [1]. First rebase the main branch because I added a config file for cpplint which will eliminate some of the errors. Then fix the remaining ones.

I rebased it, but that commit doesn't seem to change something regarding how cpplint works.

@teodutu
Copy link
Member

teodutu commented Jul 17, 2024

I didn't see the C code files were also flagging super-linter [1]. First rebase the main branch because I added a config file for cpplint which will eliminate some of the errors. Then fix the remaining ones.

I rebased it, but that commit doesn't seem to change something regarding how cpplint works.

Fuck, you,re right. I had only added CPPLINT.cfg to the internal repo. Now I've added it here as well. Rebase again and pull the latest main branch locally before doing so.

Add content related to binary-analysis.

Signed-off-by: Mihnea Firoiu <[email protected]>
@teodutu teodutu merged commit bfacda9 into security-summer-school:main Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drills Update to drills content area/infra Update to infrastructure area/reading Update to reading content kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/binary-introduction Related to the "Binary Introduction" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants