-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update binary-analysis for migration #8
Update binary-analysis for migration #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- At the end of each task's
README.md
, add a sentence like, "If you're having difficulties solving this exercise, go through [this](link to the relevant section in reading/) reading material." - Add the
src/
folder from each task tosupport/
and leave the binary files at the same level assrc/
.
chapters/binary-introduction/binary-analysis/drills/tasks/easy-to-spot/README.md
Show resolved
Hide resolved
chapters/binary-introduction/binary-analysis/drills/tasks/ghidra-killer/README.md
Show resolved
Hide resolved
chapters/binary-introduction/binary-analysis/drills/tasks/packaging-is-important/README.md
Show resolved
Hide resolved
chapters/binary-introduction/binary-analysis/drills/tasks/spaghetti/README.md
Show resolved
Hide resolved
In addition, take a look at the failing CI/CD tests and fix them [1]. For the false positives coming from spellcheck, you'll have to add them here to the wordlists via a PR [2]. Use [1] https://github.com/security-summer-school/essentials-security/pull/8/checks |
352b3ab
to
0ba6abc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just split the reading material into 4 parts and then this should be good to go.
0ba6abc
to
5121f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing for super-linter to pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To pacify super-linter, reverse the order of the sections in this file and turn "Reminders" into a level 2 heading (##
).
5121f4f
to
15a78ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see the C code files were also flagging super-linter [1]. First rebase the main
branch because I added a config file for cpplint which will eliminate some of the errors. Then fix the remaining ones.
15a78ad
to
c8bf648
Compare
I rebased it, but that commit doesn't seem to change something regarding how cpplint works. |
Fuck, you,re right. I had only added |
Add content related to binary-analysis. Signed-off-by: Mihnea Firoiu <[email protected]>
c8bf648
to
27562f2
Compare
Prerequisite Checklist
Description of changes
Update binary-analysis for migration.