Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify bazel version in .bazeliskrc since .bazelversion not working … #441

Merged
merged 3 commits into from
Dec 10, 2024
Merged

specify bazel version in .bazeliskrc since .bazelversion not working … #441

merged 3 commits into from
Dec 10, 2024

Conversation

tongke6
Copy link
Collaborator

@tongke6 tongke6 commented Dec 10, 2024

…in bzlmod

@tongke6 tongke6 requested review from shaojian-ant, anakinxc, Jamie-Cui and rivertalk and removed request for shaojian-ant December 10, 2024 04:49
@tongke6 tongke6 merged commit b91787c into main Dec 10, 2024
5 of 7 checks passed
@tongke6 tongke6 deleted the tk/pin-bazel-version branch December 10, 2024 06:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@anakinxc
Copy link
Collaborator

This basically forced everyone to use bazelisk.

Is this caused by a bug in Bazel?

@tongke6
Copy link
Collaborator Author

tongke6 commented Dec 10, 2024 •
edited
Loading

This basically forced everyone to use bazelisk.

Is this caused by a bug in Bazel?

Bazel don't respect .bazelversion in bzlmod anymore, it only works in workspace mode. bazelbuild/bazelisk#52

People can use USE_BAZEL_VERSION=7.4.1 bazel build ... to specify bazel version if not using bazelisk.

@Jamie-Cui
Copy link
Collaborator

interesting ...

@tpppppub
Copy link

This basically forced everyone to use bazelisk.
Is this caused by a bug in Bazel?

Bazel don't respect .bazelversion in bzlmod anymore, it only works in workspace mode. bazelbuild/bazelisk#52

People can use USE_BAZEL_VERSION=7.4.1 bazel build ... to specify bazel version if not using bazelisk.

Maybe we should document this explicitly here as there is no .bazelversion file anymore and bazel users do not know the version required.

@tongke6
Copy link
Collaborator Author

tongke6 commented Dec 10, 2024

@tpppppub Sure, I will submit a PR to add the instruction.

@anakinxc
Copy link
Collaborator

well done to bazelisk :D

@anakinxc
Copy link
Collaborator

@tongke6 Is it possible to just upgrade to bazel 8?

@tongke6
Copy link
Collaborator Author

tongke6 commented Dec 10, 2024

@tongke6 Is it possible to just upgrade to bazel 8?

I will give it a try when all secretflow repos have moved to bzlmod.

@Jamie-Cui
Copy link
Collaborator

image

@tongke6
Copy link
Collaborator Author

tongke6 commented Dec 10, 2024

@tpppppub add instruction in this PR: #444

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rivertalk rivertalk rivertalk approved these changes

@anakinxc anakinxc Awaiting requested review from anakinxc

@Jamie-Cui Jamie-Cui Awaiting requested review from Jamie-Cui

@shaojian-ant shaojian-ant Awaiting requested review from shaojian-ant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tongke6 @anakinxc @Jamie-Cui @tpppppub @rivertalk