Update cli command from "new" to "enhance" with Generative AI (#102)

secmon-lab · Jan 3, 2025 · 6b26d89 · 6b26d89
1 parent feebb47
commit 6b26d89
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/pkg/controller/cli/cmd.go b/pkg/controller/cli/cmd.go
@@ -46,7 +46,7 @@ func New() *CLI {
 			cmdServe(),
 			cmdRun(),
 			cmdPlay(),
-			cmdNew(),
+			cmdEnhance(),
 			{
 				Name:    "version",
 				Aliases: []string{"v"},

diff --git a/pkg/controller/cli/new.go → pkg/controller/cli/enhance.go b/pkg/controller/cli/new.go → pkg/controller/cli/enhance.go
@@ -11,20 +11,20 @@ import (
 	"github.com/urfave/cli/v3"
 )
 
-func cmdNew() *cli.Command {
+func cmdEnhance() *cli.Command {
 	return &cli.Command{
-		Name:    "new",
-		Aliases: []string{"n"},
-		Usage:   "Create new alertchain policy",
+		Name:    "enhance",
+		Aliases: []string{"e"},
+		Usage:   "Enhance alertchain policy with Generative AI",
 		Commands: []*cli.Command{
-			cmdNewIgnore(),
+			cmdEnhanceIgnore(),
 		},
 	}
 }
 
-func cmdNewIgnore() *cli.Command {
+func cmdEnhanceIgnore() *cli.Command {
 	var (
-		input           usecase.NewIgnorePolicyInput
+		input           usecase.EnhanceIgnorePolicyInput
 		alertIDSet      []string
 		geminiProjectID string
 		geminiLocation  string
@@ -111,7 +111,7 @@ func cmdNewIgnore() *cli.Command {
 			}
 			defer dbClose()
 
-			if err := usecase.NewIgnorePolicy(ctx, dbClient, geminiClient, input); err != nil {
+			if err := usecase.EnhanceIgnorePolicy(ctx, dbClient, geminiClient, input); err != nil {
 				return err
 			}
 

diff --git a/pkg/usecase/new_ignore.go → pkg/usecase/enhance_ignore.go b/pkg/usecase/new_ignore.go → pkg/usecase/enhance_ignore.go
@@ -50,15 +50,15 @@ func getRegoPackageName(policyData string) (string, error) {
 	return strings.Join(terms, "."), nil
 }
 
-type NewIgnorePolicyInput struct {
+type EnhanceIgnorePolicyInput struct {
 	AlertIDs         []types.AlertID
 	BasePolicyFile   string
 	TestDataDir      string
 	TestDataRegoPath string
 	OverWrite        bool
 }
 
-func (x NewIgnorePolicyInput) Validate() error {
+func (x EnhanceIgnorePolicyInput) Validate() error {
 	if len(x.AlertIDs) == 0 {
 		return goerr.New("AlertID is empty")
 	}
@@ -80,10 +80,10 @@ func (x NewIgnorePolicyInput) Validate() error {
 	return nil
 }
 
-func NewIgnorePolicy(ctx context.Context,
+func EnhanceIgnorePolicy(ctx context.Context,
 	dbClient interfaces.Database,
 	genAI interfaces.GenAI,
-	input NewIgnorePolicyInput,
+	input EnhanceIgnorePolicyInput,
 ) error {
 	if err := input.Validate(); err != nil {
 		return err

diff --git a/pkg/usecase/new_ignore_test.go → pkg/usecase/enhance_ignore_test.go b/pkg/usecase/new_ignore_test.go → pkg/usecase/enhance_ignore_test.go
@@ -18,7 +18,7 @@ import (
 //go:embed testdata/example_policy.rego
 var examplePolicy []byte
 
-func TestNewIgnorePolicy(t *testing.T) {
+func TestEnhanceIgnorePolicy(t *testing.T) {
 	ctx := context.Background()
 
 	alertID := types.AlertID("test-alert-id")
@@ -64,15 +64,15 @@ func TestNewIgnorePolicy(t *testing.T) {
 	// TODO: Enable this line
 	// defer os.RemoveAll(input.TestDataDir)
 
-	input := usecase.NewIgnorePolicyInput{
+	input := usecase.EnhanceIgnorePolicyInput{
 		AlertIDs:         []types.AlertID{alertID},
 		BasePolicyFile:   fd.Name(),
 		TestDataDir:      dir,
 		TestDataRegoPath: "test_rego_path",
 		OverWrite:        true,
 	}
 
-	gt.NoError(t, usecase.NewIgnorePolicy(ctx, dbClient, genAI, input))
+	gt.NoError(t, usecase.EnhanceIgnorePolicy(ctx, dbClient, genAI, input))
 
 	// Check if test data file is created
 	testDataPath := filepath.Join(input.TestDataDir, slug, "data.json")