Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker File #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docker File #1

wants to merge 1 commit into from

Conversation

LudwikPR
Copy link

Added support for Docker

sebastienvercammen
sebastienvercammen requested changes Dec 30, 2017
View reviewed changes
Copy link
Owner

@sebastienvercammen sebastienvercammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, thanks for the help! 👍

.dockerignore
@@ -0,0 +1,3 @@
node_modules
npm-debug.log
.git/
Copy link
Owner

@sebastienvercammen sebastienvercammen Dec 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to add the other Github default as well:

.github

Dockerfile
FROM node:6
WORKDIR /usr/src/app
RUN npm install
COPY . .
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how Docker works? I would assume you're telling it to clone the working directory to the working directory, effectively doing nothing, am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienvercammen sebastienvercammen sebastienvercammen requested changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LudwikPR @sebastienvercammen